Fluent Start speaking

Grammar · Tenses

I did vs I have done

Short answer: If you say when it happened, use I did. If the time isn't said and the result matters now, use I have done.

This is one of the most common slips in status updates. 'I have completed it yesterday' sounds wrong to global ears, even though the meaning is clear.

When to use what

1. I did: finished time

Use the simple past with a clear finished time: yesterday, last week, in 2019, two hours ago, on Monday.

2. I have done: no time, result now

Use have or has with the past form when you don't say when, and the result matters now.

3. Just, already, yet

These words love have done. Just means a moment ago. Already means sooner than expected. Yet is for questions and 'no'.

4. Ever and never: life experience

For experiences in your life so far, with no time said, use have done.

5. Telling the story after

Start with have done for the news. Then switch to did for the details, because now the time is known.

Side by side

I have finished the report.I finished the report yesterday.Finished time like yesterday? Use the simple past.
Have you eaten?Did you eat at the canteen?General check vs a specific finished event.
I've lost my ID card.I lost my ID card last week.First: still lost, it matters now. Second: just the story with a time.

Common mistakes

Instead ofSayWhy
I have completed it yesterday.I completed it yesterday.Yesterday is finished time. Never use have with it.
I have joined this company in 2020.I joined this company in 2020.In 2020 is finished time, so use the simple past.
I have done it just now.I did it just now.Just now points to a finished moment. Or say: I've just done it.
When have you sent the mail?When did you send the email?Questions with when ask for a time, so use did.
I didn't receive it till now.I haven't received it yet.Till now means up to this moment. Use haven't and yet.

Remember it

Time word on the table? Simple past. No time word, result in your hand? Have done. Yesterday and have never sit together.

Practice it out loud

Reading is half of it. Fluent listens to you say it and scores your clarity, free, in your browser.

Practice this guide

More grammar